Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add OpenAPI fields #644

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: add OpenAPI fields #644

merged 1 commit into from
Oct 21, 2024

Conversation

SMillerDev
Copy link
Owner

Add more descriptions, tags and components to ensure a nicer rendering.

@SMillerDev SMillerDev enabled auto-merge (squash) October 19, 2024 18:40
@SMillerDev SMillerDev force-pushed the fix/openapi/improve branch 3 times, most recently from ab7e344 to 654c2f7 Compare October 21, 2024 07:51
@SMillerDev SMillerDev merged commit 2d4a5e9 into main Oct 21, 2024
3 of 4 checks passed
@SMillerDev SMillerDev deleted the fix/openapi/improve branch October 21, 2024 07:54
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 17.80822% with 120 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (cf72033) to head (ce9f693).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/PHPDraft/Out/OpenAPI/OpenApiRenderer.php 16.31% 118 Missing ⚠️
.../PHPDraft/Model/Elements/BasicStructureElement.php 50.00% 1 Missing ⚠️
...PHPDraft/Out/OpenAPI/Tests/OpenApiRendererTest.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #644      +/-   ##
============================================
- Coverage     70.98%   65.29%   -5.69%     
- Complexity      381      416      +35     
============================================
  Files            26       26              
  Lines          1020     1118      +98     
============================================
+ Hits            724      730       +6     
- Misses          296      388      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant